[libcxx-commits] [libcxx] [libc++] Disables -Wweak-vtables diagnostics. (PR #85577)

[Nikolas Klauser via libcxx-commits]

================
@@ -27,6 +27,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _Err>
 class bad_expected_access;
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wweak-vtables")
----------------
philnik777 wrote:

Please add a comment why we disabled `-Wweak-vtables` here. We shouldn't just disable it because it happens to be diagnosed. We generally try to avoid weak vtables. FWIW I don't think we should disable it here either. We should instead provide a strong definition in the dylib if it's available on the target.

https://github.com/llvm/llvm-project/pull/85577