[libcxx-commits] [libcxx] Rework Modules CMake to be (more) idiomatic. (PR #84936)

[Mark de Wever via libcxx-commits]

================
@@ -50,10 +50,15 @@ endif()
 target_compile_options(std
   PUBLIC
     -nostdinc++
+    @LIBCXX_COMPILE_FLAGS@
+)
+target_compile_options(std
+  PRIVATE
     -Wno-reserved-module-identifier
     -Wno-reserved-user-defined-literal
-    @LIBCXX_COMPILE_FLAGS@
 )
+target_link_options(std PUBLIC -nostdlib++ -Wl,-rpath,${LIBCXX_BUILD}/lib/x86_64-unknown-linux-gnu/ -L${LIBCXX_BUILD}/lib/x86_64-unknown-linux-gnu)
----------------
mordante wrote:

This has the target `x86_64-unknown-linux-gnu` hard-coded. I expect this to fail on other platforms.

https://github.com/llvm/llvm-project/pull/84936