[libcxx-commits] [libcxx] Fix bug in documentation regarding dependencies. (PR #84930)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 12 08:20:26 PDT 2024
https://github.com/EricWF created https://github.com/llvm/llvm-project/pull/84930
The docs for building modules suggest you have to build with -j1 and
build the std modules first. Fortunetly, that's just a bug in the
documentation. By correctly listing the libraries as dependencies,
the build system will order the builds correctly.
>From bc658170bcc3a244187005adb7a5ee4ea5636822 Mon Sep 17 00:00:00 2001
From: Eric Fiselier <eric at efcs.ca>
Date: Tue, 12 Mar 2024 11:18:23 -0400
Subject: [PATCH] Fix bug in documentation regarding dependencies.
The docs for building modules suggest you have to build with -j1 and
build the std modules first. Fortunetly, that's just a bug in the
documentation. By correctly listing the libraries as dependencies,
the build system will order the builds correctly.
---
libcxx/docs/Modules.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libcxx/docs/Modules.rst b/libcxx/docs/Modules.rst
index ee2b81d3b9e7ca..234cb53cecfb27 100644
--- a/libcxx/docs/Modules.rst
+++ b/libcxx/docs/Modules.rst
@@ -206,6 +206,8 @@ This is a small sample program that uses the module ``std``. It consists of a
#
add_executable(main)
+ add_dependencies(main std)
+ target_link_libraries(std)
target_sources(main
PRIVATE
main.cpp
More information about the libcxx-commits
mailing list