[libcxx-commits] [libcxx] [libcxx] Handle changing of fr_FR locale thousand sep in Windows libcxx tests (PR #83967)

Rodrigo Salazar via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 11 17:28:29 PDT 2024


4-rodrigo-salazar wrote:

I'm thinking we can get rid of most of the cross platform checks using the above approach (by providing the value from lconv through lit config actions), so each of the apple specific, gnu version specific, windows specific checks could be removed at once. Reaching for the values from the localeconv() c api shouldn't take away from the test quality either, as it shouldn't be hitting any of the locale c++ code that is being tested.

https://github.com/llvm/llvm-project/pull/83967


More information about the libcxx-commits mailing list