[libcxx-commits] [libcxx] 0bbada9 - Actually disable the module generation tests.

Eric Fiselier via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 8 09:17:30 PST 2024


Author: Eric Fiselier
Date: 2024-03-08T12:17:07-05:00
New Revision: 0bbada93a559b604797fe57978f3eca5e41edaeb

URL: https://github.com/llvm/llvm-project/commit/0bbada93a559b604797fe57978f3eca5e41edaeb
DIFF: https://github.com/llvm/llvm-project/commit/0bbada93a559b604797fe57978f3eca5e41edaeb.diff

LOG: Actually disable the module generation tests.

LIT was never really meant to generate tests during discovery,
and we probably shouldn't be doing this.

This hack is even worse than the initial attempt because it buries the
"UNSUPPORTED" at the bottom of the test.

Added: 
    

Modified: 
    libcxx/test/libcxx/module_std.gen.py
    libcxx/test/libcxx/module_std_compat.gen.py

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/module_std.gen.py b/libcxx/test/libcxx/module_std.gen.py
index fc23985caf30de..5acaa837d37e0a 100644
--- a/libcxx/test/libcxx/module_std.gen.py
+++ b/libcxx/test/libcxx/module_std.gen.py
@@ -16,7 +16,11 @@
 # to be one monolitic test. Since the test doesn't take very long it's
 # not a huge issue.
 
+# WARNING: Disabled at the bottom. Fix this test and remove the UNSUPPORTED line
+# TODO: Re-enable this test once we understand why it keeps timing out.
+
 # RUN: %{python} %s %{libcxx-dir}/utils
+# END.
 
 import sys
 
@@ -35,4 +39,5 @@
 
 
 print("//--- module_std.sh.cpp")
+print('// UNSUPPORTED: clang')
 generator.write_test("std")

diff  --git a/libcxx/test/libcxx/module_std_compat.gen.py b/libcxx/test/libcxx/module_std_compat.gen.py
index 000aa299861220..a502276a1ccfc5 100644
--- a/libcxx/test/libcxx/module_std_compat.gen.py
+++ b/libcxx/test/libcxx/module_std_compat.gen.py
@@ -16,7 +16,11 @@
 # to be one monolitic test. Since the test doesn't take very long it's
 # not a huge issue.
 
+# WARNING: Disabled at the bottom. Fix this test and remove the UNSUPPORTED line
+# TODO: Re-enable this test once we understand why it keeps timing out.
+
 # RUN: %{python} %s %{libcxx-dir}/utils
+# END.
 
 import sys
 
@@ -36,6 +40,7 @@
 
 
 print("//--- module_std_compat.sh.cpp")
+print("// UNSUPPORTED: clang")
 generator.write_test(
     "std.compat",
     module_c_headers,


        


More information about the libcxx-commits mailing list