[libcxx-commits] [libcxx] [libcxx][test] Create feature host-can-create-symlinks (PR #82204)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 8 06:53:42 PST 2024


================
@@ -474,6 +476,39 @@ def _getAndroidDeviceApi(cfg):
     ),
 ]
 
+
+# Creation of symlinks require elevated privileges on Windows unless
+# Windows developer mode is enabled.
+def check_unprivileged_symlinks(cfg):
+    if not platform.system().lower().startswith("windows"):
+        return True
+
+    temp_file = tempfile.NamedTemporaryFile(delete=False)
----------------
ldionne wrote:

The comment I left below about host vs target distinction made me realize that this check is not implemented properly. You need to implement this check via e.g. `programSucceeds` (which will properly run the program on the target we're testing).

https://github.com/llvm/llvm-project/pull/82204


More information about the libcxx-commits mailing list