[libcxx-commits] [libcxx] [libc++] Add [[nodiscard]] to static numeric limit functions (PR #83748)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 5 03:25:27 PST 2024


https://github.com/philnik777 approved this pull request.

> @philnik777 I am unable to make the ClangFormat check pass, because the `expect-warning` comments are so long. If I format the file, the comment is at the wrong line. I looked at e.g. `bit.dodiscard_extensions.verify.cpp` which is also not formatted. Is it okay to leave it like this?

Yeah, that's fine. We should really just disable the formatting check for `.verify.cpp` tests, since this problem exists in almost all of them.

LGTM with the last comment addressed.

https://github.com/llvm/llvm-project/pull/83748


More information about the libcxx-commits mailing list