[libcxx-commits] [libcxx] [libc++][test] Don't include `test_format_context.h` in `parse.pass.cpp` (PR #83734)
A. Jiang via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 4 22:03:18 PST 2024
================
@@ -41,7 +41,7 @@ constexpr void test(StringViewT fmt, std::size_t offset) {
static_assert(std::semiregular<decltype(formatter)>);
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx);
- assert(it == fmt.end() - offset);
+ assert(std::to_address(it) == std::to_address(fmt.end()) - offset);
----------------
frederick-vs-ja wrote:
I added `// LWG3989` for the lines changed to use `std::to_address`. Should I furtherly mention that this possibly has effect due to the implementation strategy of MSVC STL's `basic_format_parse_context`?
https://github.com/llvm/llvm-project/pull/83734
More information about the libcxx-commits
mailing list