[libcxx-commits] [libcxx] [libc++][test] Don't include `test_format_context.h` in `format.tuple/parse.pass.cpp` (PR #83734)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 3 10:10:35 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: A. Jiang (frederick-vs-ja)
<details>
<summary>Changes</summary>
The test doesn't need to call `test_format_context_create` to create a `basic_format_context`, so it shouldn't include `test_format_context.h`.
Discovered when implementing `formatter<tuple>` in MSVC STL. With the inclusion removed, local test passes when using enhanced MSVC STL.
---
Full diff: https://github.com/llvm/llvm-project/pull/83734.diff
1 Files Affected:
- (modified) libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp (-1)
``````````diff
diff --git a/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp b/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
index 5cabbda63dd02e..313f8ef8d220d0 100644
--- a/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
@@ -27,7 +27,6 @@
#include <tuple>
#include <utility>
-#include "test_format_context.h"
#include "test_macros.h"
#include "make_string.h"
``````````
</details>
https://github.com/llvm/llvm-project/pull/83734
More information about the libcxx-commits
mailing list