[libcxx-commits] [libcxx] Introduce __config_epilogue suitable for #undef-ing certain defines from __config (PR #93015)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 25 08:24:24 PDT 2024


https://github.com/ldionne requested changes to this pull request.

I don't quite understand how this is so different from modifying the `__config` header itself. Is there a benefit to it?

Also, with us splitting up `__config` a bit, there may not be a single place where these `#undefs` can live.

Finally, I think it would be a lot better to add support for NVCC in libc++ itself than provide more tools for people to hack up the libc++ headers on the side.

All in all, I'm not a big fan of this approach.

https://github.com/llvm/llvm-project/pull/93015


More information about the libcxx-commits mailing list