[libcxx-commits] [clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 20 04:33:18 PDT 2024


mstorsjo wrote:

> Hm, this seems to affect some feature detection (and constraints) later on, though I don't see why/how removing the specification of `--unwindlib=none` to the driver (leaving it only to the linker) would cause that:
> 
> https://github.com/llvm/llvm-project/blob/1c046ca3f3254944483251bdc9c843e72d7f7796/libunwind/src/CMakeLists.txt#L99-L106

I actually tested doing this cleanup back around when I wrote this - sorry I never got around to amending the comment here explaining what has to be done. The case with libunwind is a bit non-obvious.

I rebased my test change from 2022, see https://github.com/mstorsjo/llvm-project/commit/runtimes-link-options-unwindlib-none. Can you try this out and see if it fixes the issue you're seeing?

https://github.com/llvm/llvm-project/pull/93429


More information about the libcxx-commits mailing list