[libcxx-commits] [libcxx] [libc++] Improve aligned allocation support with picolibc. (PR #96086)

Simon Tatham via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 19 08:58:40 PDT 2024


statham-arm wrote:

I wondered if I should go further than this in reworking `support/count_new.h`. Would it be better to remove the existing cases that directly call `_aligned_malloc` and `posix_memalign`, on the basis that `__libcpp_aligned_helper` has already made the same choice? Or even to remove `allocate_aligned_impl` and `free_aligned_impl` completely, and have the rest of this support module just call `__libcpp_aligned_helper` and `__libcpp_free_helper` directly?

I've been conservative for the moment, because I'm not set up to test on all of the affected platforms. But I'm happy to change the patch to be more drastic if reviewers think that's a good idea!


https://github.com/llvm/llvm-project/pull/96086


More information about the libcxx-commits mailing list