[libcxx-commits] [libcxx] [libc++] Add default copy ctor to "__chrono/exception.h" (PR #95338)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 13 14:01:00 PDT 2024


zeroomega wrote:

> I would tend to say this LGTM.
> 
> I think this is safe to land once CI is green, and if @mordante thinks this change isn't good we can always revert. I'd normally say "wait for Mark's approval" but I guess this is breaking your roll and in Mark's timezone it may take some time for him to see this, so I'd say go ahead once CI is green.

Thanks for the code review.

I am looking at the pre-submit checks. There are 2 failures. One is 

```
  llvm-libc++-shared.cfg.in :: /home/runner/_work/llvm-project/llvm-project/build/generic-cxx20/test/libcxx/module_std.gen.py/module_std.sh.cpp
  llvm-libc++-shared.cfg.in :: /home/runner/_work/llvm-project/llvm-project/build/generic-cxx20/test/libcxx/module_std_compat.gen.py/module_std_compat.sh.cpp
  ```

This one appeared on other PR as well, e.g. https://github.com/llvm/llvm-project/actions/runs/9504393714/job/26202667672 so I think it is probably unrelated to my change.

The other one:

```
readelf: Warning: Further warnings about bogus end-of-sibling markers suppressed
readelf: Warning: Unrecognized form: 0x23
readelf: Warning: Unrecognized form: 0x22
readelf: Warning: Unrecognized form: 0x22
readelf: Warning: Unrecognized form: 0x23
readelf: Warning: DIE at offset 0x17d3 refers to abbreviation number 1497 which does not exist
+ false
Error: Process completed with exit code 1.
```

I am not sure. But I feel my change would be unlikely to cause issues like this.
Is there any ongoing libcxx CI issue that is happening? Do I need to rebase my change against ToT to pick up some potential CI related fixes?


https://github.com/llvm/llvm-project/pull/95338


More information about the libcxx-commits mailing list