[libcxx-commits] [libcxx] [libc++] change the visibility of libc++ header to public in libcxx module (PR #91240)

[Martin Storsjö via libcxx-commits]

mstorsjo wrote:

> I suspect the Windows CI is failing because a newer LLVM was somehow installed on the machines, which could be due to #95228 being tested. If that's the case, then I think we just learned that the state of CI machines on Windows is shared across all PRs, which is a bit concerning.
> 
> For the scope of this change I think we can just ignore the failures on Windows.

It’s not that the other jobs caused a new version to be installed; the jobs don’t cross contaminate the environment (that’d be concerning).

The base images used for the runners are continuously updated. Today, it seems like they’ve rolled out a new image that contained a newer version of LLVM out of the box. The command we used for installing the version of LLVM we wanted failed, when the installation turned out to be a downgrade.

As part of #95228 I added a flag to tell it that we’re ok with downgrading - to prevent this from becoming an issue in the future, when a newer version appears in the base image again.

https://github.com/llvm/llvm-project/pull/91240