[libcxx-commits] [libcxx] [libcxx] Align `__recommend() + 1` by __endian_factor (PR #90292)

[Louis Dionne via libcxx-commits]

ldionne wrote:

Basically, folks passing the `-fsized-deallocation` Clang flag (which is off by default in LLVM 18) will get the wrong deallocation size passed to their `operator delete` when storage has been allocated/deallocated by `std::string`. I don't know what the result of passing the wrong size will usually be, I guess it depends on what the custom `operator delete` does, but I could definitely imagine it being a correctness concern.

@alk @ckennelly There seems to be a claim that Google's using this flag at large scale internally. If it's possible to detail the impact of this regression a bit more, it might help to give at least one "real world" point of view on this.

https://github.com/llvm/llvm-project/pull/90292