[libcxx-commits] [libcxx] [libcxx] Align `__recommend() + 1` by __endian_factor (PR #90292)

[Louis Dionne via libcxx-commits]

ldionne wrote:

@alk Ah, I managed to make your reproducer work. I was using incorrect flags, it needs optimizations enabled to trigger. This is a slightly simplified version that shows the issue on Clang 18 but not on 17 and 16: https://godbolt.org/z/nYYvG74d7

@DimitryAndric Thanks a lot for the information.

So then this is indeed a regression in LLVM 18. Since this is happening in `std::string` which is very widely used, I believe this may have enough impact to be worth another 18.1.x release. WDYT?

https://github.com/llvm/llvm-project/pull/90292