[libcxx-commits] [libcxx] [libcxx][test][AIX] address more platform differences in locale tests (PR #94826)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 11 13:59:46 PDT 2024


================
@@ -204,17 +209,20 @@ int main(int, char**)
             std::noshowbase(ios);
         }
         {   // negative, showbase
-            std::string v = currency_symbol + "-1,234,567.89";
-            std::showbase(ios);
-            typedef cpp17_input_iterator<const char*> I;
-            long double ex;
-            std::ios_base::iostate err = std::ios_base::goodbit;
-            I iter = f.get(I(v.data()), I(v.data() + v.size()),
-                                                false, ios, err, ex);
-            assert(base(iter) == v.data() + v.size());
-            assert(err == std::ios_base::eofbit);
-            assert(ex == -123456789);
-            std::noshowbase(ios);
+#ifdef _AIX
+          std::string v = "-" + currency_symbol + "1,234,567.89";
----------------
ldionne wrote:

Ack. I'm concerned about the maintainability of our current approach, but you're right that this patch doesn't make things significantly worse nor does it stray from the status quo.

https://github.com/llvm/llvm-project/pull/94826


More information about the libcxx-commits mailing list