[libcxx-commits] [libcxx] [libc++][TZDB] Adds basics of zoned_time class. (PR #94999)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 11 12:01:33 PDT 2024


================
@@ -0,0 +1,45 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: no-filesystem, no-localization, no-tzdb
+
+// XFAIL: libcpp-has-no-experimental-tzdb
+// XFAIL: availability-tzdb-missing
+
+// <chrono>
+
+// template<class Duration, class TimeZonePtr = const time_zone*>
+// class zoned_time;
+//
+// TimeZonePtr get_time_zone() const;
+
+#include <chrono>
+#include <concepts>
+
+#include "test_offset_time_zone.h"
+
+int main(int, char**) {
+  {
+    const std::chrono::time_zone* tz = std::chrono::locate_zone("UTC");
----------------
ldionne wrote:

You seem to be testing two things at the same time here. One of them is the const-ness of the function, and the other one is with a `time_zone const*` vs a `int*`. Perhaps make line 38 non-const and then add a third test that calls `get_time_zone()` on a `const zoned_time` object? That way each test case is orthogonal.

https://github.com/llvm/llvm-project/pull/94999


More information about the libcxx-commits mailing list