[libcxx-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

[via libcxx-commits]

zeroomega wrote:

> ADDITIONAL_COMPILE_FLAGS(clang)

I did some test. I added `// ADDITIONAL_COMPILE_FLAGS(clang): -Wno-deprecated` to `std/time/time.duration/types.pass.cpp` and this test did disappear from the list of the failed tests. It doesn't have to be `cl-style-warnings` . 

I am not sure why this issue only happens when running test on `runtimes-x86_64-pc-windows-msvc` but not the runtimes test on linux-x64. But I think I understand why this issue didn't pop up in libcxx upstream windows bots. It is very likely that the upstream bots are using the last release version of clang/llvm while ours are using Tip of the Tree, which may have new warnings enabled by default (and those warnings were not in the old llvm/clang releases).

I don't think adding `// ADDITIONAL_COMPILE_FLAGS(clang): -Wno-deprecated` to the failing tests is a good idea. There are 471 tests are failing. The issue should be fixed by refactoring the code to avoid triggering the `deprecated-copy-with-user-provided-dtor` warning.

https://github.com/llvm/llvm-project/pull/90394