[libcxx-commits] [libcxx] Reverts around time_zone (PR #95058)

Vitaly Buka via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 11 11:02:22 PDT 2024


vitalybuka wrote:

I guess in general we arguing about these two approaches:

1. @fmayer reverts
2. @mordante investigates
3. @mordante asks @fmayer for help
4. @mordante relands with the fix

and 

1. @fmayer reports
2. built-bot spam all users on blame list of  unrelated patches, and spent time investigating
3. maybe we miss another regression, because bot was red anyway
4. downstream user pickup the issues and investigate
5. @mordante investigates
6. @mordante asks @fmayer for help
7. @mordante lands a fix

To me @mordante and @fmayer time investment of Revert <= No-Revert, but No1 is less likely annoy the community and downstream users.

So I strongly advocate for No1 and revert when in doubt.

https://github.com/llvm/llvm-project/pull/95058


More information about the libcxx-commits mailing list