[libcxx-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

Vitaly Buka via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 11 08:43:47 PDT 2024


vitalybuka wrote:

> The test is not the fastest, so enabling sanitizer might trigger a time-out. This feature is still experimental in libc++ and I've not looked at performance improvements. (I know there are several improvements that can be done, but I first want working code and benchmarks.)

It can be the case, it's flaky with asan as well https://lab.llvm.org/buildbot/#/builders/239/builds/7415
and when it pass it's very slow with asas

```
--------------------------------------------------------------------------
1045.64s: llvm-libc++-shared.cfg.in :: std/time/time.zone/time.zone.timezone/time.zone.members/get_info.local_time.pass.cpp
1004.27s: llvm-libc++-shared.cfg.in :: std/atomics/atomics.ref/compare_exchange_weak.pass.cpp
997.76s: llvm-libc++-shared.cfg.in :: std/atomics/atomics.ref/compare_exchange_strong.pass.cpp
303.88s: llvm-libc++-shared.cfg.in :: std/atomics/atomics.ref/wait.pass.cpp
...
```

If we confident that this is just timeout, we need to split or speedup this test. Long tests also a problem, less serious, but still.

https://github.com/llvm/llvm-project/pull/89537


More information about the libcxx-commits mailing list