[libcxx-commits] [libcxx] Reverts around time_zone (PR #95058)

[Mark de Wever via libcxx-commits]

mordante wrote:

> > "lowest effort revert back to green without enough information to then move forward" kind of thing.
> 
> This is not only our bot, but others as well.

The HWSAN is fixed by disabling the test in the CI right? I got an e-mail of the sanitizer failure, however in my experience the sanitizer builds tend to be flaky so I typically look whether they fail for multiple builds. (I spend a lot of time in the past to investigate build failures and the next build was green again.)

I have not gotten e-mails of other build failures.

> Also, quoting LLVM policy:
> 
> > If you break a buildbot in a way which can’t be quickly fixed, please revert.
> 
> It's not about effort, it's about not stacking breakages on top of each other. 

Louis asked how we can then move forward. That is part of the same policy

"It is not considered reasonable to revert without at least the promise to provide a means for the patch author to debug the root issue. If a situation arises where a public reproducer can not be shared for some reason (e.g. requires hardware patch author doesn’t have access to, sharp regression in compile time of internal workload, etc.), the reverter is expected to be proactive about working with the patch author to debug and test candidate patches."

So I would like to know how we can move ahead before reverting. Since these changes can depend on the system configuration it's hard to debug them on these systems.

https://github.com/llvm/llvm-project/pull/95058