[libcxx-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

[via libcxx-commits]

zeroomega wrote:

Hi, we started to see libcxx tests failures on our Windows x64 msvc bots when running tests for `runtimes-x86_64-pc-windows-msvc`, with error message:

```

Exit Code: 1

Command Output (stdout):
--
# RUN: at line 4
C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe -c C:\b\s\w\ir\x\w\llvm_build\runtimes\runtimes-x86_64-pc-windows-msvc-bins\test\libcxx\double_include.gen.py\chrono.sh.cpp -o C:\b\s\w\ir\x\w\llvm_build\runtimes\runtimes-x86_64-pc-windows-msvc-bins\test\libcxx\double_include.gen.py\Output\chrono.sh.cpp.dir\t.tmp.first.o --driver-mode=g++ --target=x86_64-pc-windows-msvc -fms-runtime-lib=static -nostdinc++ -I C:/b/s/w/ir/x/w/llvm_build/include/x86_64-pc-windows-msvc/c++/v1 -I C:/b/s/w/ir/x/w/llvm_build/include/c++/v1 -I C:/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -std=c++26 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier -Wdeprecated-copy -Wdeprecated-copy-dtor -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions -Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete -Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -Werror=thread-safety -Wuser-defined-warnings
# executed command: C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe -c 'C:\b\s\w\ir\x\w\llvm_build\runtimes\runtimes-x86_64-pc-windows-msvc-bins\test\libcxx\double_include.gen.py\chrono.sh.cpp' -o 'C:\b\s\w\ir\x\w\llvm_build\runtimes\runtimes-x86_64-pc-windows-msvc-bins\test\libcxx\double_include.gen.py\Output\chrono.sh.cpp.dir\t.tmp.first.o' --driver-mode=g++ --target=x86_64-pc-windows-msvc -fms-runtime-lib=static -nostdinc++ -I C:/b/s/w/ir/x/w/llvm_build/include/x86_64-pc-windows-msvc/c++/v1 -I C:/b/s/w/ir/x/w/llvm_build/include/c++/v1 -I C:/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/support -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -std=c++26 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-noexcept-type -Wno-atomic-alignment -Wno-reserved-module-identifier -Wdeprecated-copy -Wdeprecated-copy-dtor -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -Wno-local-type-template-args -Wno-c++11-extensions -Wno-unknown-pragmas -Wno-pass-failed -Wno-mismatched-new-delete -Wno-redundant-move -Wno-self-move -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -Werror=thread-safety -Wuser-defined-warnings
# .---command stderr------------
# | In file included from C:\b\s\w\ir\x\w\llvm_build\runtimes\runtimes-x86_64-pc-windows-msvc-bins\test\libcxx\double_include.gen.py\chrono.sh.cpp:9:
# | In file included from C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\chrono:926:
# | C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\__chrono/exception.h:51:55: error: definition of implicit copy constructor for 'nonexistent_local_time' is deprecated because it has a user-provided destructor [-Werror,-Wdeprecated-copy-with-user-provided-dtor]
# |    51 |   _LIBCPP_AVAILABILITY_TZDB _LIBCPP_EXPORTED_FROM_ABI ~nonexistent_local_time() override; // exported as key function
# |       |                                                       ^
# | C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\__chrono/exception.h:74:9: note: in implicit copy constructor for 'std::chrono::nonexistent_local_time' first required here
# |    74 |   throw nonexistent_local_time(__time, __info);
# |       |         ^
# | C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\__chrono/exception.h:92:55: error: definition of implicit copy constructor for 'ambiguous_local_time' is deprecated because it has a user-provided destructor [-Werror,-Wdeprecated-copy-with-user-provided-dtor]
# |    92 |   _LIBCPP_AVAILABILITY_TZDB _LIBCPP_EXPORTED_FROM_ABI ~ambiguous_local_time() override; // exported as key function
# |       |                                                       ^
# | C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\__chrono/exception.h:115:9: note: in implicit copy constructor for 'std::chrono::ambiguous_local_time' first required here
# |   115 |   throw ambiguous_local_time(__time, __info);
# |       |         ^
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--
```

Could you take a look please?

https://github.com/llvm/llvm-project/pull/90394