[libcxx-commits] [libcxx] [libc++][NFC] Simplify the implementation of `__promote` (PR #81379)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 10 05:44:32 PDT 2024


EricWF wrote:

> I think we should `#if` the old code as a whole for Clang 17 just to get this patch unblocked, and we can remove that "workaround" when we drop support for Clang 17. It's so easy to clean these up that I wouldn't stall this patch just for that reason.

This is supposed to be a simplification, meaning it only provides value if it simplifies the code. We've just added a second implementation, which is not a simplification, it's a complication.

There's no need to land code like this while it doesn't provided the stated value.

This should have waited until all supported compilers allowed us to do it.


https://github.com/llvm/llvm-project/pull/81379


More information about the libcxx-commits mailing list