[libcxx-commits] [libcxx] [libcxxabi] [libc++][libc++abi] Minor follow-up changes after ptrauth upstreaming (PR #87481)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 7 11:03:07 PDT 2024


================
@@ -275,13 +275,15 @@ struct __type_info_implementations {
           __impl;
 };
 
-#    if defined(__arm64__) && __has_cpp_attribute(clang::ptrauth_vtable_pointer)
-#      if __has_feature(ptrauth_type_info_discriminated_vtable_pointer)
+#    if __has_cpp_attribute(_Clang::__ptrauth_vtable_pointer__) && __has_feature(__ptrauth_calls__)
+#      if __has_feature(__ptrauth_vtable_address_discrimination__) ||                                                  \
+          __has_feature(__ptrauth_vtable_type_discrimination__)
----------------
ldionne wrote:

@ahmedbougacha @asl @kovdan01

Do these conditions seem right to you? This is important to get right since it's ABI affecting.

https://github.com/llvm/llvm-project/pull/87481


More information about the libcxx-commits mailing list