[libcxx-commits] [clang] [libcxx] [Clang] Implement resolution for CWG1835 (PR #92957)

Matheus Izvekov via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 7 07:23:46 PDT 2024


https://github.com/mizvekov approved this pull request.

LGTM save a few minor cleanups needed.

I think this patch has an incredible amount of noise due to amount of cosmetic changes caused by reformatting, specially due to changing parameters and such.

This is fine for now and I am not suggesting you go back and do it for this patch, but I think it would have been helpful to pre-clang-format the file, and offload more of the minor changes into a previous patch.

https://github.com/llvm/llvm-project/pull/92957


More information about the libcxx-commits mailing list