[libcxx-commits] [clang] [clang-tools-extra] [libcxx] Reland "[clang] Enable sized deallocation by default in C++14 onwards" (PR #90373)

[Pengcheng Wang via libcxx-commits]

wangpc-pp wrote:

> This broke building clang on Windows with PGO:
> 
> ```
> FAILED: bin/clang-repl.exe lib/clang-repl.lib 
> cmd.exe /C "cmd.exe /C "D:\task_171745452431588\fetches\cmake\bin\cmake.exe -E __create_def D:\task_171745452431588\fetches\llvm-project\build\stage2\build\tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\.\exports.def D:\task_171745452431588\fetches\llvm-project\build\stage2\build\tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\.\exports.def.objs --nm=D:\task_171745452431588\fetches\clang\bin\llvm-nm.exe && cd D:\task_171745452431588\fetches\llvm-project\build\stage2\build" && D:\task_171745452431588\fetches\cmake\bin\cmake.exe -E vs_link_exe --intdir=tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir --rc="D:\task_171745452431588\fetches\vs\Windows Kits\10\bin\10.0.22621.0\x64\rc.exe" --mt="D:\task_171745452431588\fetches\vs\Windows Kits\10\bin\10.0.22621.0\x64\mt.exe" --manifests  -- D:\task_171745452431588\fetches\clang\bin\lld-link.exe /nologo @CMakeFiles\clang-repl.rsp  /out:bin\clang-repl.exe /implib:lib\clang-repl.lib /pdb:bin\clang-repl.pdb /version:0.0 /machine:x64 /STACK:10000000 /libpath:"D:/task_171745452431588/fetches/clang/lib/clang/19/lib/windows" /INCREMENTAL:NO /subsystem:console   /EXPORT:??_7type_info@@6B@ /EXPORT:?__type_info_root_node@@3U__type_info_node@@A /EXPORT:?nothrow at std@@3Unothrow_t at 1@B /EXPORT:_Init_thread_abort /EXPORT:_Init_thread_epoch /EXPORT:_Init_thread_footer /EXPORT:_Init_thread_header /EXPORT:_tls_index /EXPORT:??2 at YAPEAX_K@Z /EXPORT:??3 at YAXPEAX@Z /EXPORT:??_U at YAPEAX_K@Z /EXPORT:??_V at YAXPEAX@Z /EXPORT:??3 at YAXPEAX_K@Z /DEF:"D:/task_171745452431588/fetches/llvm-project/build/stage2/build/tools/clang/tools/clang-repl/clang-repl.def"  -Wl,--long-plt /DEF:tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\.\exports.def  && cd ."
> LINK: command "D:\task_171745452431588\fetches\clang\bin\lld-link.exe /nologo @CMakeFiles\clang-repl.rsp /out:bin\clang-repl.exe /implib:lib\clang-repl.lib /pdb:bin\clang-repl.pdb /version:0.0 /machine:x64 /STACK:10000000 /libpath:D:/task_171745452431588/fetches/clang/lib/clang/19/lib/windows /INCREMENTAL:NO /subsystem:console /EXPORT:??_7type_info@@6B@ /EXPORT:?__type_info_root_node@@3U__type_info_node@@A /EXPORT:?nothrow at std@@3Unothrow_t at 1@B /EXPORT:_Init_thread_abort /EXPORT:_Init_thread_epoch /EXPORT:_Init_thread_footer /EXPORT:_Init_thread_header /EXPORT:_tls_index /EXPORT:??2 at YAPEAX_K@Z /EXPORT:??3 at YAXPEAX@Z /EXPORT:??_U at YAPEAX_K@Z /EXPORT:??_V at YAXPEAX@Z /EXPORT:??3 at YAXPEAX_K@Z /DEF:D:/task_171745452431588/fetches/llvm-project/build/stage2/build/tools/clang/tools/clang-repl/clang-repl.def -Wl,--long-plt /DEF:tools\clang\tools\clang-repl\CMakeFiles\clang-repl.dir\.\exports.def /MANIFEST /MANIFESTFILE:bin\clang-repl.exe.manifest" failed (exit code 1) with the following output:
> lld-link: error: <root>: undefined symbol: __profc_??$?0$$BY03DUdesc
> lld-link: error: <root>: undefined symbol: __profc_??$?0$$BY04DW4OptionHidden
> lld-link: error: <root>: undefined symbol: __profc_??$?0$$BY09DW4OptionHidden
> lld-link: error: <root>: undefined symbol: __profc_??$?0$$BY0BC
> lld-link: error: <root>: undefined symbol: __profc_??$?0$$BY0N
> lld-link: error: <root>: undefined symbol: __profc_??$?0W4FormattingFlags
> lld-link: error: <root>: undefined symbol: __profc_??$?4$$BY05D
> lld-link: error: <root>: undefined symbol: __profc_??$?6PEBD
> lld-link: error: <root>: undefined symbol: __profc_??$_Emplace_reallocate
> lld-link: error: <root>: undefined symbol: __profc_??$_Reallocate_for
> lld-link: error: <root>: undefined symbol: __profc_??$_Reallocate_grow_by
> lld-link: error: <root>: undefined symbol: __profc_??$_Traits_find 
> lld-link: error: <root>: undefined symbol: __profc_??$_Traits_rfind
> lld-link: error: <root>: undefined symbol: __profc_??$_Uninitialized_move
> lld-link: error: <root>: undefined symbol: __profc_??$addValue
> lld-link: error: <root>: undefined symbol: __profc_??$handleErrors 
> lld-link: error: <root>: undefined symbol: __profc_??$setValue
> lld-link: error: <root>: undefined symbol: __profc_??0?$OptionValueCopy
> lld-link: error: <root>: undefined symbol: __profc_??0Completion
> lld-link: error: <root>: undefined symbol: __profc_??0ErrorList
> lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see all errors)
> ```

I don't have such environment, can you provide more details? And it seems these undefined symbols are not symbols for `delete`.

https://github.com/llvm/llvm-project/pull/90373