[libcxx-commits] [libcxx] [libc++] Make std::pair trivially copyable if its members are (PR #89652)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 3 13:06:00 PDT 2024


EricWF wrote:

Thank you for all of the information.

> I'm not at all dismissing the concerns. In fact, as stated above, Louis and I have talked about this extensively (I realize that that's not something visible to others). I just don't think that these pre-existing problems should block this patch.

If I thought this were meaningfully ABI breaking, I would disagree. But I don't, so I'm OK with proceeding with it.
That said, I still have a concern with this line of thinking. 

If we agree that `X` is a problem, we should fix `X`. We shouldn't continue to make `X` worse.

But again, here I don't think there's a real ABI issue. 

We should certainly have a bigger discussion about the importance or non-importance of ABI stability across (A) dialects & (B) compilers.  At some point it may come to affect how we build the library.

https://github.com/llvm/llvm-project/pull/89652


More information about the libcxx-commits mailing list