[libcxx-commits] [libcxx] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 31 13:08:05 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r ef67664d81b395e6dea9586a1a508323ad2a9de7...66650b256022c4781850e8334d8c2f16e10cbe65 libcxx/utils/libcxx/test/config.py libcxx/utils/libcxx/test/format.py libcxx/utils/libcxx/test/params.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- config.py	2024-07-31 20:02:16.000000 +0000
+++ config.py	2024-07-31 20:07:31.338545 +0000
@@ -50,10 +50,17 @@
                         action.pretty(config, lit_config.params), feature.pretty(config)
                     )
                 )
 
     # Print the basic substitutions
-    for sub in ("%{cxx}", "%{flags}", "%{compile_flags}", "%{link_flags}", "%{benchmark_flags}", "%{exec}"):
+    for sub in (
+        "%{cxx}",
+        "%{flags}",
+        "%{compile_flags}",
+        "%{link_flags}",
+        "%{benchmark_flags}",
+        "%{exec}",
+    ):
         note("Using {} substitution: '{}'".format(sub, _getSubstitution(sub, config)))
 
     # Print all available features
     note("All available features: {}".format(", ".join(sorted(config.available_features))))
--- format.py	2024-07-31 20:02:16.000000 +0000
+++ format.py	2024-07-31 20:07:31.453430 +0000
@@ -27,11 +27,18 @@
     return tmpDir, tmpBase
 
 
 def _checkBaseSubstitutions(substitutions):
     substitutions = [s for (s, _) in substitutions]
-    for s in ["%{cxx}", "%{compile_flags}", "%{link_flags}", "%{benchmark_flags}", "%{flags}", "%{exec}"]:
+    for s in [
+        "%{cxx}",
+        "%{compile_flags}",
+        "%{link_flags}",
+        "%{benchmark_flags}",
+        "%{flags}",
+        "%{exec}",
+    ]:
         assert s in substitutions, "Required substitution {} was not provided".format(s)
 
 def _executeScriptInternal(test, litConfig, commands):
     """
     Returns (stdout, stderr, exitCode, timeoutInfo, parsedCommands)

``````````

</details>


https://github.com/llvm/llvm-project/pull/101399


More information about the libcxx-commits mailing list