[libcxx-commits] [libcxx] [libcxx] Make terminal check always false for `print` on GPU (PR #99259)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 31 07:13:46 PDT 2024


================
@@ -1223,6 +1223,11 @@ typedef __char32_t char32_t;
 #    define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER
 #  endif
 
+// Clang supports targeting GPU architectures.
+#  if (defined(__AMDGPU__) || defined(__NVPTX__)) && defined(_LIBCPP_COMPILER_CLANG_BASED)
+#    define _LIBCPP_TARGETING_GPU
+#endif
----------------
ldionne wrote:

I would rather not introduce this setting. First, it's too specific (it shouldn't pin the compiler), and I think it's better (for now at least) to use the targets themselves in the 2 places below where they're needed (in `chrono`).

https://github.com/llvm/llvm-project/pull/99259


More information about the libcxx-commits mailing list