[libcxx-commits] [libcxx] [libc++][math] Fix acceptance of convertible types in `std::isnan()` and `std::isinf()` (PR #98952)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 31 07:04:05 PDT 2024


https://github.com/ldionne requested changes to this pull request.

Do I understand correctly that the `convertible-to` tests fail only in the combination of libc++/C++03/glibc?

It seems to me like the cure may be worse than the disease in this case, I'm not certain this is worth addressing given the complexity it introduces. In a certain way, this can be seen as a bug in glibc since there's no such issue in other standard modes and in other standard libraries.

Instead, we could add the missing test coverage and disable it with a comment based on `TEST_STD_VER <= 03`

https://github.com/llvm/llvm-project/pull/98952


More information about the libcxx-commits mailing list