[libcxx-commits] [libcxx] [libcxx][test] Do not assume array::iterator is a pointer (PR #100603)

Christopher Di Bella via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 30 10:44:31 PDT 2024


================
@@ -183,8 +183,17 @@ struct NonConstComparable {
   friend constexpr bool operator==(NonConstComparable&, const NonConstComparable&) { return true; }
 };
 
+// note: this should really use `std::const_iterator`
----------------
cjdb wrote:

> Oh, I meant using the issue in the todo as `TODO(<#issue-number>): <reason>`.

This was a part of my conditional LGTM. I will make it clearer in future reviews.

https://github.com/llvm/llvm-project/pull/100603


More information about the libcxx-commits mailing list