[libcxx-commits] [libcxx] [libc++] Fix -Wsign-compare warning in `ranges::search` (PR #100983)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Hewill Kang (hewillk)

<details>
<summary>Changes</summary>

The type returned by `ranges::size` is not guaranteed to be unsigned, so using `ranges::distance` here ensures that it always returns a signed type.

---
Full diff: https://github.com/llvm/llvm-project/pull/100983.diff


1 Files Affected:

- (modified) libcxx/include/__algorithm/ranges_search.h (+2-2) 


``````````diff
diff --git a/libcxx/include/__algorithm/ranges_search.h b/libcxx/include/__algorithm/ranges_search.h
index 55294c60631b1..0f1cc5cd3095b 100644
--- a/libcxx/include/__algorithm/ranges_search.h
+++ b/libcxx/include/__algorithm/ranges_search.h
@@ -98,11 +98,11 @@ struct __fn {
       _Range1&& __range1, _Range2&& __range2, _Pred __pred = {}, _Proj1 __proj1 = {}, _Proj2 __proj2 = {}) const {
     auto __first1 = ranges::begin(__range1);
     if constexpr (sized_range<_Range2>) {
-      auto __size2 = ranges::size(__range2);
+      auto __size2 = ranges::distance(__range2);
       if (__size2 == 0)
         return {__first1, __first1};
       if constexpr (sized_range<_Range1>) {
-        auto __size1 = ranges::size(__range1);
+        auto __size1 = ranges::distance(__range1);
         if (__size1 < __size2) {
           ranges::advance(__first1, ranges::end(__range1));
           return {__first1, __first1};

``````````

</details>


https://github.com/llvm/llvm-project/pull/100983