[libcxx-commits] [libcxx] [libc++] Remove functions deprecated in C++17 and removed in C++20 (PR #100914)

[Nikolas Klauser via libcxx-commits]

================
@@ -22,8 +22,8 @@
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 template <class _Tp>
-_LIBCPP_NODISCARD _LIBCPP_HIDE_FROM_ABI _LIBCPP_NO_CFI _LIBCPP_DEPRECATED_IN_CXX17 pair<_Tp*, ptrdiff_t>
-get_temporary_buffer(ptrdiff_t __n) _NOEXCEPT {
+_LIBCPP_NODISCARD _LIBCPP_HIDE_FROM_ABI _LIBCPP_NO_CFI pair<_Tp*, ptrdiff_t>
+__get_temporary_buffer(ptrdiff_t __n) _NOEXCEPT {
----------------
philnik777 wrote:

I don't think adding an internal version is the right call here. We should replace the call sites instead. I'd probably go for a `unique_ptr` and calling `allocator<T>::allocate()`, since that makes it trivial to implement [P2562R1](https://wg21.link/P2562R1).

https://github.com/llvm/llvm-project/pull/100914