[libcxx-commits] [libcxx] [libcxx] [regex] add `[[clang::fallthrough]]` to suppress fallthrough warning (PR #100821)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 27 10:03:44 PDT 2024


mordante wrote:

> question for reviewer: what is the proper etiquette for stacked diffs? Should I open two PRs or have one PR with two commits?

It's only possible to make stacked reviews for members of the LLVM project since it requires write access to the repository. I prefer you wait uploading the next patch until this one lands. Having two patches mixed causes reviewers to review the same code twice.

https://github.com/llvm/llvm-project/pull/100821


More information about the libcxx-commits mailing list