[libcxx-commits] [clang] [libcxx] Reapply "[Clang] Implement resolution for CWG1835 (#92957, #98547)" (PR #100425)

Matheus Izvekov via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 26 09:58:36 PDT 2024


mizvekov wrote:

> @AaronBallman @cor3ntin @mizvekov So, I've made improvements to our implementation of `isTemplateArgumentList` (not on this branch) that allow us to issue a warning instead of an error for most of the cases where applying the DR breaks existing code:
> 

That's great, thanks for following up on this!

I am still concerned about the double error on the `t.A<1 < 4>::x` example.
The ideal outcome would be to turn the second error into a note.
How feasible to fix you think that is?
Otherwise, I don't think this is a blocker for merging this, we can improve it on a follow up patch.

> Since we can look past the potential _template-argument-list_ in most cases, we could probably apply CWG1835 in all language modes with minimal impact on existing code.

Yes, I would certainly support that!


https://github.com/llvm/llvm-project/pull/100425


More information about the libcxx-commits mailing list