[libcxx-commits] [libcxx] [libc++] Remove outdated setting of LIBCXX_CXX_ABI_LIBRARY_PATH (PR #100631)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 25 11:51:46 PDT 2024


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/100631

LIBCXX_CXX_ABI_LIBRARY_PATH is used to determine the path of the ABI library in use. It shouldn't be necessary to set it explicitly in order to run the tests, since the test suite has its own configuration mechanism.

>From 6d33ce2cde8b36683f1603173aecab33f80c2411 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 15 Jul 2024 15:37:48 -0400
Subject: [PATCH] [libc++] Remove outdated setting of
 LIBCXX_CXX_ABI_LIBRARY_PATH

LIBCXX_CXX_ABI_LIBRARY_PATH is used to determine the path of the ABI
library in use. It shouldn't be necessary to set it explicitly in order
to run the tests, since the test suite has its own configuration
mechanism.
---
 libcxx/test/CMakeLists.txt | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/libcxx/test/CMakeLists.txt b/libcxx/test/CMakeLists.txt
index 001b29efcfefa..29f9ddc020702 100644
--- a/libcxx/test/CMakeLists.txt
+++ b/libcxx/test/CMakeLists.txt
@@ -1,12 +1,6 @@
 include(HandleLitArguments)
 add_subdirectory(tools)
 
-# By default, libcxx and libcxxabi share a library directory.
-if (NOT LIBCXX_CXX_ABI_LIBRARY_PATH)
-  set(LIBCXX_CXX_ABI_LIBRARY_PATH "${LIBCXX_LIBRARY_DIR}" CACHE PATH
-      "The path to libc++abi library.")
-endif()
-
 set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!")
 set(SERIALIZED_LIT_PARAMS "# Lit parameters serialized here for llvm-lit to pick them up\n")
 



More information about the libcxx-commits mailing list