[libcxx-commits] [libcxx] [libc++] Make std::unique_lock available with _LIBCPP_HAS_NO_THREADS (PR #99562)

Paul Kirth via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 24 15:24:55 PDT 2024


================
@@ -0,0 +1,88 @@
+//===----------------------------------------------------------------------===//
----------------
ilovepi wrote:

hmm, we still have several tests that still have `no-threads`
- thread.lock.unique.locking/lock.pass.cpp
- thread.lock.unique.cons/mutex.pass.cpp
- thread.lock.unique.cons/mutex_duration.pass.cpp
- thread.lock.unique.cons/mutex_try_to_lock.pass.cpp
- thread.lock.unique.cons/mutex_time_point.pass.cpp

Of these 3 use `std::mutex`: 
- thread.lock.unique.cons/mutex.pass.cpp
- thread.lock.unique.cons/mutex_try_to_lock.pass.cpp
- thread.lock.unique.locking/lock.pass.cpp

I think most of the API surface is tested in those tests. I see couple of  constructors/destructors, lock, unlock, release ... I think maybe we're only missing try_for/try_until, and maybe some of the other assertions on move construction.

In light of those tests still using `std::mutex` do you still want me to add more tests? I'm happy to, but I can't think of much outside the try* APIs that should get exercised.

https://github.com/llvm/llvm-project/pull/99562


More information about the libcxx-commits mailing list