[libcxx-commits] [libcxx] 1b60c38 - [libc++][NFC] Add comment about __builtin_verbose_trap per review comment

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2024-07-23T13:57:08-04:00
New Revision: 1b60c38eee1485c01f60451d9e0ea75a6323ea0f

URL: https://github.com/llvm/llvm-project/commit/1b60c38eee1485c01f60451d9e0ea75a6323ea0f
DIFF: https://github.com/llvm/llvm-project/commit/1b60c38eee1485c01f60451d9e0ea75a6323ea0f.diff

LOG: [libc++][NFC] Add comment about __builtin_verbose_trap per review comment

Added: 
    

Modified: 
    libcxx/vendor/llvm/default_assertion_handler.in

Removed: 
    


################################################################################
diff  --git a/libcxx/vendor/llvm/default_assertion_handler.in b/libcxx/vendor/llvm/default_assertion_handler.in
index 3b6d6b2cca53c..8f37b9089ece8 100644
--- a/libcxx/vendor/llvm/default_assertion_handler.in
+++ b/libcxx/vendor/llvm/default_assertion_handler.in
@@ -26,6 +26,7 @@
 #  if __has_builtin(__builtin_verbose_trap)
 // AppleClang shipped a slightly 
diff erent version of __builtin_verbose_trap from the upstream
 // version before upstream Clang actually got the builtin.
+// TODO: Remove once AppleClang supports the two-arguments version of the builtin.
 #    if defined(_LIBCPP_APPLE_CLANG_VER) && _LIBCPP_APPLE_CLANG_VER < 17000
 #      define _LIBCPP_ASSERTION_HANDLER(message) __builtin_verbose_trap(message)
 #    else