[libcxx-commits] [libcxx] [libc++] Make std::pair trivially copyable if its members are (PR #89652)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 23 10:49:07 PDT 2024


ldionne wrote:

@cjdb I am still waiting for a reproducer for the assignment example you showed above, please LMK once you have it.

If we don't manage to figure out whether there's something broken with this patch soon I would err on the side of reverting it for LLVM 19 stability's sake, but let's at least dig a little bit before we do that to ensure we don't revert something that's entirely correct. We know for a fact that this patch is a behavior change, that's why it's behind the ABI flag. That alone shouldn't be enough to mandate a revert. If we do figure out that it's broken, or if we have strong suspicion that it is, then as I said we should revert.

https://github.com/llvm/llvm-project/pull/89652


More information about the libcxx-commits mailing list