[libcxx-commits] [libcxx] [libc++][Android] Fix Android bugs in the CI Dockerfile (PR #99623)

[Ryan Prichard via libcxx-commits]

rprichard wrote:

> We don't use the `buildkite-builder` image anymore AFAICT and we should clean that up.

This image is the actual base of android-buildkite-builder, but they could be merged. It looks like we aren't using `buildkite-builder` anymore.

> Is there a reason for having both `Android Builder Base Image` and `Android Buildkite Builder Image`?

https://github.com/llvm/llvm-project/pull/71954 created the current organization. I'm guessing it was an initial step towards migrating Android testing to GitHub Actions.

> Is there a reason for keeping the Android builder image in the same Dockerfile as the Github runners?

There might be some code that ought to be shared between Android and Linux? It's unclear to me how much that is -- the CMake install step, I suppose.

I think I need to know more about how the GitHub Actions testing works, and whether it's feasible to migrate Android over to it.

https://github.com/llvm/llvm-project/pull/99623