[libcxx-commits] [libcxx] [openmp] [libc++] basic_ios<wchar_t> cannot store fill character WCHAR_MAX (PR #89305)

[via libcxx-commits]

zeroomega wrote:

@daltenty Thanks for looking into this.  At this point I am 90% confident that the test failure on `01-coff-print-basic-details.test` is an issue on our side. 
I did a local build and rerun the stage2 build of `llvm-debuginfo-analyzer` (which is what was failing in the unit test) with `-v` and noticed that the stage 1's libc++ linker flag (`/Users/haowei/SRC/llvm-prebuilts/clang/mac-amd64/lib/libc++.a`) was incorrectly passed through:

```
_  stage2-bins git:(bad) _ ninja llvm-debuginfo-analyzer -v
[1/1] : && /Users/haowei/SRC/llvm-project/build_stage2/./bin/clang++ --sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffile-prefix-map=/Users/haowei/SRC/llvm-project/build_stage2/tools/clang/stage2-bins=../../../../ -ffile-prefix-map=/Users/haowei/SRC/llvm-project/= -no-canonical-prefixes -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk -mmacosx-version-min=10.13 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -nostdlib++ /Users/haowei/SRC/llvm-prebuilts/clang/mac-amd64/lib/libc++.a -stdlib=libc++ -static-libstdc++ -fuse-ld=lld -Wl,--color-diagnostics -Wl,-lto_library -Wl,/Users/haowei/SRC/llvm-project/build_stage2/./lib/libLTO.dylib    -Wl,-dead_strip tools/llvm-debuginfo-analyzer/CMakeFiles/llvm-debuginfo-analyzer.dir/llvm-debuginfo-analyzer.cpp.o tools/llvm-debuginfo-analyzer/CMakeFiles/llvm-debuginfo-analyzer.dir/Options.cpp.o -o bin/llvm-debuginfo-analyzer  -Wl,-rpath, at loader_path/../lib  lib/libLLVMX86Desc.a  lib/libLLVMARMDesc.a  lib/libLLVMAArch64Desc.a  lib/libLLVMRISCVDesc.a  lib/libLLVMX86Disassembler.a  lib/libLLVMARMDisassembler.a  lib/libLLVMAArch64Disassembler.a  lib/libLLVMRISCVDisassembler.a  lib/libLLVMX86Info.a  lib/libLLVMARMInfo.a  lib/libLLVMAArch64Info.a  lib/libLLVMRISCVInfo.a  lib/libLLVMBinaryFormat.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMDebugInfoLogicalView.a  lib/libLLVMDebugInfoPDB.a  lib/libLLVMMC.a  lib/libLLVMMCDisassembler.a  lib/libLLVMObject.a  lib/libLLVMSupport.a  lib/libLLVMARMDesc.a  lib/libLLVMARMInfo.a  lib/libLLVMARMUtils.a  lib/libLLVMAArch64Desc.a  lib/libLLVMCodeGenTypes.a  lib/libLLVMAArch64Info.a  lib/libLLVMAArch64Utils.a  lib/libLLVMRISCVDesc.a  lib/libLLVMRISCVInfo.a  lib/libLLVMMCDisassembler.a  lib/libLLVMDebugInfoMSF.a  lib/libLLVMDebugInfoDWARF.a  lib/libLLVMObject.a  lib/libLLVMIRReader.a  lib/libLLVMBitReader.a  lib/libLLVMAsmParser.a  lib/libLLVMCore.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libLLVMMCParser.a  lib/libLLVMMC.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMTextAPI.a  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libLLVMSupport.a  lib/libLLVMDemangle.a  -lm && :
clang++: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]
clang++: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]
clang++: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]

```

So the stage2 clang, when building this binary was linked to the host's libcxx. I will try to manually correct it to the stage2 libcxx to see if the failure disappear. 


https://github.com/llvm/llvm-project/pull/89305