[libcxx-commits] [libcxx] [libcxx] Cache file attributes during directory iteration. (PR #93316)

[Louis Dionne via libcxx-commits]

================
@@ -77,13 +77,13 @@ class __dir_stream {
   bool assign() {
     if (!wcscmp(__data_.cFileName, L".") || !wcscmp(__data_.cFileName, L".."))
       return false;
-    // FIXME: Cache more of this
-    // directory_entry::__cached_data cdata;
-    // cdata.__type_ = get_file_type(__data_);
-    // cdata.__size_ = get_file_size(__data_);
-    // cdata.__write_time_ = get_write_time(__data_);
     __entry_.__assign_iter_entry(
----------------
ldionne wrote:

Is there a reason why you didn't also modify `__create_iter_result` at https://github.com/llvm/llvm-project/blob/7e37d021022b0786a704a89abae2014692158b2f/libcxx/include/__filesystem/directory_entry.h#L227 ?

https://github.com/llvm/llvm-project/pull/93316