[libcxx-commits] [libcxx] [libcxx][test] Update picolib xfails (PR #99631)

[David Spickett via libcxx-commits]

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/99631

clang_modules_include.gen.py works now, and I added some background to classic_table.pass.cpp.

Opened https://github.com/picolibc/picolibc/issues/778 to see if that one is possible to fix.

>From 2b52ccd0c0cf9d22447802eb6b34d37bae2dd0d6 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Fri, 19 Jul 2024 09:28:16 +0000
Subject: [PATCH] [libcxx][test] Update picolib xfails

clang_modules_include.gen.py works now, and I added
some background to /classic_table.pass.cpp.

Opened https://github.com/picolibc/picolibc/issues/778
to see if that one is possible to fix.
---
 libcxx/test/libcxx/clang_modules_include.gen.py               | 3 ---
 .../facet.ctype.char.statics/classic_table.pass.cpp           | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/libcxx/test/libcxx/clang_modules_include.gen.py b/libcxx/test/libcxx/clang_modules_include.gen.py
index 7ba4bf0326240..f084c38a8fbd3 100644
--- a/libcxx/test/libcxx/clang_modules_include.gen.py
+++ b/libcxx/test/libcxx/clang_modules_include.gen.py
@@ -37,9 +37,6 @@
 // TODO: Investigate this failure
 // UNSUPPORTED: LIBCXX-FREEBSD-FIXME
 
-// TODO: Investigate this failure
-// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
-
 {lit_header_restrictions.get(header, '')}
 
 #include <{header}>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp
index 50c60180ce0dd..1bd9fc88c72db 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp
@@ -6,6 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// Picolibc/newlib checks for the blank flag in isprint, which needs to be false
+// for tab. So they removed the _B flag from the ctype data, which causes this
+// test to fail.
+// See https://github.com/picolibc/picolibc/issues/778.
 // XFAIL: LIBCXX-PICOLIBC-FIXME
 
 // <locale>