[libcxx-commits] [libcxx] 50b5bb7 - [libc++] Add comment about matching standard version in apple-install-libcxx

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2024-07-18T16:49:53-04:00
New Revision: 50b5bb717ca5d2ec78587551bc90a8ddd0cc8983

URL: https://github.com/llvm/llvm-project/commit/50b5bb717ca5d2ec78587551bc90a8ddd0cc8983
DIFF: https://github.com/llvm/llvm-project/commit/50b5bb717ca5d2ec78587551bc90a8ddd0cc8983.diff

LOG: [libc++] Add comment about matching standard version in apple-install-libcxx

This was forgotten when I landed #99086

Added: 
    

Modified: 
    libcxx/utils/ci/apple-install-libcxx.sh

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/ci/apple-install-libcxx.sh b/libcxx/utils/ci/apple-install-libcxx.sh
index e5698ce93bc12..4872253a266a8 100755
--- a/libcxx/utils/ci/apple-install-libcxx.sh
+++ b/libcxx/utils/ci/apple-install-libcxx.sh
@@ -118,6 +118,7 @@ for arch in ${architectures}; do
 
     step "Building shims to make libc++ compatible with the system libc++ on Apple platforms when running the tests"
     shims_library="${build_dir}/${arch}/apple-system-shims.a"
+    # Note that this doesn't need to match the Standard version used to build the rest of the library.
     xcrun clang++ -c -std=c++2b -target ${target} "${llvm_root}/libcxxabi/src/vendor/apple/shims.cpp" -static -o "${shims_library}"
 
     step "Building libc++.dylib and libc++abi.dylib for architecture ${arch}"