[libcxx-commits] [libcxx] [libc++][strings] P2591R5: Concatenation of strings and string views (PR #88389)

[Mark de Wever via libcxx-commits]

mordante wrote:

> > @Zingam The LLVM-19 branching is in two weeks. It would be great if you have time to get this review done before that time. Is there a way for me to help you getting this done?
> 
> I still cannot resolve the issue with building the benchmark:
> 
> > $ ninja cxx-benchmarks
> > [1/134] Performing configure step for 'google-benchmark-libcxx'
> > ...
> > -- Failed to find LLVM FileCheck
> > -- Google Benchmark version: v0.0.0, normalized to 0.0.0
> > -- Enabling additional flags: -DINCLUDE_DIRECTORIES=/home//llvm-project/third-party/benchmark/include
> > -- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES -- success
> > -- Performing Test HAVE_STD_REGEX -- failed to compile
> > -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
> > -- Performing Test HAVE_POSIX_REGEX -- failed to compile

This looks very odd. I wonder whether this is a regex library issue or a different configuration error. I expect the latter since `<regex>` is not available too.


https://github.com/llvm/llvm-project/pull/88389