[libcxx-commits] [libcxx] [libc++][test] XFAIL sized deallocation tests for AIX, z/OS, and MinGW (PR #98960)

Xing Xue via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 15 13:45:01 PDT 2024


https://github.com/xingxue-ibm created https://github.com/llvm/llvm-project/pull/98960

The sized deallocation test cases fail on AIX, z/OS, and MinGW because they default to `-fno-sized-deallocation`. This patch XFAILs these test cases for the affected targets. Once they change the default, we will get `unexpectedly pass`.

>From c26ca8ca1aa04641dc6d7eb8d66f02af6e5ddd2b Mon Sep 17 00:00:00 2001
From: Xing Xue <xingxue at outlook.com>
Date: Mon, 15 Jul 2024 20:35:45 +0000
Subject: [PATCH] XFAIL sized deallocation tests for AIX, z/OS, and MinGW.

---
 .../new.delete/new.delete.array/sized_delete_array14.pass.cpp  | 3 +++
 .../new.delete/new.delete.single/sized_delete14.pass.cpp       | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
index 01467ca9911e1..15df87d279867 100644
--- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
+++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
@@ -15,6 +15,9 @@
 // XFAIL: apple-clang
 // XFAIL: using-built-library-before-llvm-11
 
+// AIX, z/OS, and MinGW default to -fno-sized-deallocation.
+// XFAIL: target={{.+}}-aix{{.*}}, target={{.+}}-zos{{.*}}, target={{.+}}-mingw32{{.*}}
+
 #include <new>
 #include <cstddef>
 #include <cstdlib>
diff --git a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp
index fd7f2dbabdacc..d3c736fcbf135 100644
--- a/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp
+++ b/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp
@@ -15,6 +15,9 @@
 // XFAIL: apple-clang
 // XFAIL: using-built-library-before-llvm-11
 
+// AIX, z/OS, and MinGW default to -fno-sized-deallocation.
+// XFAIL: target={{.+}}-aix{{.*}}, target={{.+}}-zos{{.*}}, target={{.+}}-mingw32{{.*}}
+
 #include <new>
 #include <cstddef>
 #include <cstdlib>



More information about the libcxx-commits mailing list