[libcxx-commits] [libcxx] [libc++][test] Updates sized deallocation tests. (PR #97833)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 15 11:19:05 PDT 2024


ldionne wrote:

> The affected test cases are under the `std` sub-directory because the standard expects `-fsized-deallocation` to be the default. So it is better to `XFAIL` those test cases for targets where `-fno-sized-deallocation` is the default. With `XFAIL` we will get `unexpectedly pass` once the affected targets change the default. I will post a PR for that shortly.

Yes, this would be my preferred approach as well. I'd like us to move away from passing `-fwhatever` as much as possible. Of course we sometimes have to, but since Clang now does the right thing by default (apart from exceptions as discussed above), I would XFAIL the platforms on which it "doesn't behave correctly".

https://github.com/llvm/llvm-project/pull/97833


More information about the libcxx-commits mailing list