[libcxx-commits] [libcxx] [libc++] Handle _LIBCPP_HAS_NO_{THREADS, LOCALIZATION} consistently with other carve-outs (PR #98319)
Mark de Wever via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Jul 13 03:55:57 PDT 2024
https://github.com/mordante approved this pull request.
> > I can see this change affecting some users. For example, those who use CMake's `try_compile` and include `<thread>` to test whether threading is available. For that reason I feel we should add this change to the release notes.
>
> I'm really not too concerned about that -- I think these are relatively niche features so the likelihood of someone relying on `try_compile` to detect something like this seems rather small. You bring up an excellent point, I just have the feeling that most people probably won't notice.
I'm also not sure how big the issue would be, however I wanted to make sure it was considered.
Thanks for the release notes, LGTM!
https://github.com/llvm/llvm-project/pull/98319
More information about the libcxx-commits
mailing list