[libcxx-commits] [libcxx] [libc++][strings] P2591R5: Concatenation of strings and string views (PR #88389)

[Hristo Hristov via libcxx-commits]

H-G-Hristov wrote:

@mordante @hawkinsw Thank you for asking to help! I've been rather busy and unable to do much libc++ related work. It would be great to complete this PR in time for 19.0.
What we have so far: 
1. I used Will's prototype implementation with minor adjustments (Thanks @hawkinsw)
2. I also believe addressed the comments regarding the tests.
Unfortunately I had issues with building the benchmark suite on my Ubuntu 22.04 installation. The CMake configuration would fails, so I haven't been able to do the requested benchmarks and I haven't had the time to try again. It's probably an issue with my system.
I'll give the benchmarks a try again.

@mordante Is there anything else besides the benchmarks that you'd like to be addressed?

https://github.com/llvm/llvm-project/pull/88389